assertj icon indicating copy to clipboard operation
assertj copied to clipboard

License header not in line with Apache license guidance

Open scordio opened this issue 2 years ago • 3 comments

According to the Apache license guidance, the current license header is not fully in line with the suggested template:

--- assertj-header	2023-04-09 11:26:08.000000000 +0200
+++ apache-header	2023-04-09 09:50:55.000000000 +0200
@@ -1,3 +1,5 @@
+Copyright [yyyy] [name of copyright owner]
+
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
@@ -9,5 +11,3 @@
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
-
-Copyright 2012-2023 the original author or authors.

scordio avatar Apr 09 '23 08:04 scordio

Aside from moving up the copyright section, what should be the name of the copyright owner?

For example:

  • Mockito has chosen Mockito contributors as the copyright owner.
  • MapStruct has chosen MapStruct Authors as the copyright owner.

On the other side, projects like JUnit, Spring Framework and Spring Boot use the generic copyright definition:

Copyright ... the original author or authors.

scordio avatar Apr 09 '23 08:04 scordio

@scordio I'm ok with the generic copyright as it is used by major open source projects.

Then I guess it's just a matter of moving the copyright at the beginning (although I don't see why it would make a legal difference)

joel-costigliola avatar May 19 '24 14:05 joel-costigliola

Indeed, it's mostly a cosmetic issue.

In addition, our config can be simplified now that mathieucarbou/license-maven-plugin#532 ~is~ will be fixed but in the next release only 😅.

So, on hold until license-maven-plugin 4.6 is released.

scordio avatar May 20 '24 09:05 scordio