assertj-assertions-generator icon indicating copy to clipboard operation
assertj-assertions-generator copied to clipboard

Inconsistent imports

Open lhannest opened this issue 4 years ago • 0 comments

Problem: I'm having classes generated with imports like:

import java.util.Objects;
import org.assertj.core.api.AbstractObjectAssert;
import org.assertj.core.internal.Iterables;
import org.assertj.core.util.Objects;

And this results in the compile error:

'java.util.Objects' is already defined in a single-type import

Solution:

I'd like to just use fully qualified class names instead of import statements.

I see https://github.com/assertj/assertj-assertions-generator/issues/97 requested using imports instead of fully qualified class names. Maybe both should be supported, but it should be configurable which one is being used.

Also it looks like this the use of fully qualified class names was already implemented for 2.2.1 with https://github.com/assertj/assertj-assertions-generator/commit/73d3c5e584e33b1509b058a2707c1ece00ee8bee?

Versions: I'm using assertj-assertions-generator version 2.2.1, assertj-assertions-generator-maven-plugin version 2.2.0, and assertj-core version 3.21.0.

lhannest avatar Sep 23 '21 14:09 lhannest