assertj-assertions-generator icon indicating copy to clipboard operation
assertj-assertions-generator copied to clipboard

Published 20 hours ago • verified publisher icon assertj

Remove deprecation warnings from generated assertions

Open ebramirez opened this issue 4 years ago • 5 comments

The assertions generated uses org.assertj.core.util.Objects.areEqual and org.assertj.core.util.Objects.areEqualArrays which are deprecated and show in the applications warning logs.

Should use the suggested methods instead.

ebramirez avatar Jun 11 '20 13:06 ebramirez

Fair point, keen to contribute it @ebramirez?

joel-costigliola avatar Jun 13 '20 05:06 joel-costigliola

Sure!

Here you have it: #144

@joel-costigliola By the way, to run the tests I had to add the javax.annotation-api test dependency. I have not pushed that change as part of the PR just in case this was intentional. Is this a known thing?

ebramirez avatar Jun 15 '20 11:06 ebramirez

This project was developed with the JDK 8 which provides it but I guess you are using JDK 11 (or even 14!)

joel-costigliola avatar Jun 17 '20 11:06 joel-costigliola

You absolutely right, I completely forgot about that change.

ebramirez avatar Jun 17 '20 11:06 ebramirez

Just wondering, is there a specific reason why this change can't be release yet?

rob-valor avatar Dec 04 '20 10:12 rob-valor