flowcraft icon indicating copy to clipboard operation
flowcraft copied to clipboard

remove optional true

Open cimendes opened this issue 6 years ago • 1 comments

With the "optional true" in the output field, this process will never fail. If the download (for whatever reason) fails, the user should know :P

I don't know if there was any reason to add that optional true, if there was, please comment here!


This change is Reviewable

cimendes avatar Jul 15 '19 11:07 cimendes

Codecov Report

Merging #210 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #210   +/-   ##
=======================================
  Coverage   41.97%   41.97%           
=======================================
  Files          72       72           
  Lines        6464     6464           
=======================================
  Hits         2713     2713           
  Misses       3751     3751

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8a8574...c5fe03f. Read the comment docs.

codecov-io avatar Jul 15 '19 11:07 codecov-io