attachinary icon indicating copy to clipboard operation
attachinary copied to clipboard

Published 20 hours ago • verified publisher icon assembler

Fix for Active Record callbacks

Open fabn opened this issue 9 years ago • 6 comments

Will solve #138

fabn avatar Sep 24 '16 10:09 fabn

@fabn can you add a test for this?. Testing is something we need to improve. If it's not that difficult, it will be great to have some test coverage of this code

orlando avatar Dec 26 '16 15:12 orlando

@orlando I did that and much more but I din't receive any feedback. Could you please take a look into this?

Thanks.

fabn avatar Oct 19 '17 17:10 fabn

@fabn Awesome!. I'll take a look today.

Thank you for your patience

orlando avatar Oct 19 '17 17:10 orlando

@orlando a merge, maybe?

sharq1 avatar Feb 01 '21 10:02 sharq1

Hey @sharq1,

Sorry, I used to use this library in production but not anymore. I don't think I can review this change since is so big and includes things that are not necessary to have in the main repo (example bootstrap-sprockets)

orlando avatar Feb 24 '21 18:02 orlando

I'm still using this gem (my fork) in a couple of production projects on rails 5.2 but now that activestorage is out and cloudinary support that natively I don't know if is still worth to maintain this gem. However if you're interested in merging this I can collaborate in my spare time.

fabn avatar Feb 24 '21 18:02 fabn