Assem Medhat
Assem Medhat
The failing test (https://github.com/lfortran/lfortran/actions/runs/12251263956/job/34176739756) works for me locally. It's usually related to the optimization done by llvm, It considers some of the ASR is dead code and removes it and...
I test all the issues linked to this PR and they work as intended.
> ```clojure > (Allocatable > (Array > (Character 1 -2 () PointerString) ;; is this expected to be DescriptorArray or PointerString? > [(() > ())] > DescriptorArray > ) >...
@certik it's ready. the new physical type works, I'll need to utilize size and capacity in another PR. maybe you can wait till I finish some of @gxyd suggestions and...
@certik so the key goal here is to make clean ASR, right? as using assignment statement with incompatible sides aren't an issue in the backend we just use runtime function...
Yeah I think explicit ASR casting is better way to to assignments and argument passing. This may even can get rid of the `visit_expr_wrapper` changes that Gaurav and I were...
The PR is ready for review. I'm pushing documentation, It'd be helpful to read it before reviewing this.
@gxyd Thanks for the great feedback. I'll try to handle your suggestions today. Update : I left some comments on your suggestions, let me know what you think.
Thanks for reviewing that guys @Pranavchiku @gxyd . really appreciate it. @certik I'll resolve conflicts with the reference files, then I think it's ready to get merged.
@certik let me know what you think about the new changes. after merging that I'll be pushing a PR to utilize size and capacity.