Assaf Morami comments

Results 150 comments of


                                            Assaf Morami

CosmWasm v1

> So, I did this > > * [Scrt 46 cosmos-sdk#167](https://github.com/scrtlabs/cosmos-sdk/pull/167) > * [Cosmos SDK v46 CosmWasm/wasmd#863](https://github.com/CosmWasm/wasmd/pull/863) > > and > > * [cosmos sdk 46 upgrade cosmos/ibc-go#1653](https://github.com/cosmos/ibc-go/pull/1653) > >...

CosmWasm v1

But yeah please base new work on the cosmwasm-v1 branch ❤️

CosmWasm v1

> It is my understanding that the GRPC gateway could get us around this but I don't know how accurate that is. Yes that's accurate.

CosmWasm v1

> OK, so basically -- if we're fundamentally good with "we won't break exchange API's if go to 46" -- I'd like to either invite you guys to the Notional...

CosmWasm v1

# How to test an upgrade with LocalSecret ## Step 1 Start a v1.3 chain. Port 9091 open for secret.js tests. ```bash docker run -it -p 9091:9091 --name localsecret ghcr.io/scrtlabs/localsecret:v1.3.1...

CosmWasm v1: Pass `is_caller_a_contract` in `Env`

This issue is actually easy to do, we just have to extend the `Env` sturct and populate it somewhere in the vicinity of [this](https://github.com/enigmampc/SecretNetwork/blob/f591ed0cb3af28608df3bf19d6cfb733cca48100/cosmwasm/packages/wasmi-runtime/src/wasm/contract_validation.rs#L169-L180).

'secretd export' prints info logs to STDOUT not STDERR when initializing the enclave.

Yes logs should go to stderr

Null response from `DistQuery::Rewards` when there are no rewards

@liorbond is this fixed in v1.4?

The Only snip721 Reference Implementation I Could Find Is GPL-3.0 Licensed, Do my NFTs and Dapps Accessing Them Have to Be Open Source?

You should ask in https://github.com/baedrik/snip721-reference-impl for clarifications. IANAL, but IMO the UI is not a derivative of the contract code, thus not bound by the SNIP-721 reference implementation license.

Macbook(M1) keeps asking keychain password when secretcli interact with Ledger(Nano S)?

The only way as far as I know is to re-add your keys into secretcli on `--keyring-backend test` mode