vanity icon indicating copy to clipboard operation
vanity copied to clipboard

Vanity works with garb 0.8.x or below (not above)

Open gamafranco opened this issue 10 years ago • 5 comments

Garb is on version 0.9.x. but Vanity only runs on garb 0.8.x.

The google metric file breaks when it tries to call Grab::Resource.

gamafranco avatar Jul 12 '14 00:07 gamafranco

Hm, thanks for the report. Looks related to https://github.com/assaf/vanity/issues/151

phillbaker avatar Jul 12 '14 02:07 phillbaker

It is, sorry. GA integration is broken on vanity due to Garb for two reasons:

  1. Garb 0.9.x discontinued Garb:Resource so only 0.8.x works
  2. google changed the API and Garb 0.8.5 is broken - need to support the most recent version

So, AFAIK, vanity just needs to support 0.9.x

Feel free to mark this one as duplicate and close it. Thanks!

gamafranco avatar Jul 12 '14 10:07 gamafranco

@gamafranco can you post your google metric file?

phillbaker avatar Jul 12 '14 19:07 phillbaker

Oh, nevermind, https://github.com/assaf/vanity/blob/master/lib/vanity/metric/google_analytics.rb#L66 seems to be the issue.

phillbaker avatar Jul 12 '14 19:07 phillbaker

Yes, that's it. Sorry for not being more clear.

gamafranco avatar Jul 12 '14 23:07 gamafranco