module-zero-forsaken icon indicating copy to clipboard operation
module-zero-forsaken copied to clipboard

Published 20 hours ago • verified publisher icon aspnetboilerplate

Created Abp.EntityFramework.SettingStore

Open wocar opened this issue 8 years ago • 3 comments

Tests passed 👍 Created the nuget locally Abp.EntityFramework.SettingStore-beta2 See aspnetboilerplate/aspnetboilerplate/issues/2152

wocar avatar May 23 '17 18:05 wocar

Thanks a lot for your contribution. I'll review it in a short time.

hikalkan avatar May 23 '17 18:05 hikalkan

Thank you, first time contributing might've Missed something don't know... I'm glad to do it. Amazing framework 😌

wocar avatar May 23 '17 18:05 wocar

Hi,

One question is that: How this new module is supposed to use? I think we should add a DbSet<Setting> property to our DbContext. Right? If so, it would be better to define an interface, like ISettingDbContext that should be implemented by the DbContext. Second improvement would be renaming SettingModule to AbpEntityFrameworkSettingStoreModule.

hikalkan avatar Jul 18 '17 13:07 hikalkan