SignalR-Client-Cpp icon indicating copy to clipboard operation
SignalR-Client-Cpp copied to clipboard

v141 toolchain support (VS2017) and examples of building a single dll

Open boczar opened this issue 3 years ago • 3 comments

So, this change probably contains more than needed, but I wanted to demonstrate the spirit of my work.

The most obvious one is suppressing additional warnings, ideally I'd figure out why they are happing in the first place. Secondly, I've added two batch files and two example triplet files to build a single .dll (vs. the 7 that get generated by default).

Thirdly, I made some refactoring so that you can compile/link against the library without the cpprestsdk dependency. Right now if the library is built with USE_CPPRESTSDK but the application doesn't define that macro, you'll get nasty stack memory overwrites when using the signalr_client_config structure. I moved out the cpprestsdk specific configuration options to its own class which is optional for the application. If you do define the macro, you have to distribute/include the cpprestsdk headers and a fair amount of other dependencies (like boost 😫).

boczar avatar Apr 29 '21 03:04 boczar

CLA assistant check
All CLA requirements met.

ghost avatar Apr 29 '21 03:04 ghost

@BrennanConroy - The multiple connect test failed on linux, I'm pretty sure I didn't touch that part. Can the tests be rerun?

boczar avatar Apr 29 '21 22:04 boczar

This is great! Would love to see a static / less dependency version

RayKoopa avatar Mar 30 '22 22:03 RayKoopa