LibraryManager icon indicating copy to clipboard operation
LibraryManager copied to clipboard

RCL + Libman: Restored files don't get packed / published at the correct location in final app.

Open TFTomSun opened this issue 4 years ago • 3 comments
trafficstars

Copy from the original issue I filed in the AspNet.Core repo: https://github.com/dotnet/aspnetcore/issues/34039

Describe the bug

Files that are restored with the Microsoft.Web.LibraryManager.Build (LibMan) inside a Razor Class Library (RCL) are not deployed to the correct location in the final consuming app (e.g. Blazor Server App). Instead of being deployed to: wwwroot/_content/<RCL Package Name>/ they are deployed to wwwroot/

This happens only if the files are not yet restored when you pack / publish the app. Once the files are restore they are correctly deployed in subsequent builds.

dotnet version: 5.0.300 environments: dotnet cli (e.g. dotnet pack) Visual Studio (pack context menu)

Solution

I found out that the ResolveCurrentProjectStaticWebAssetsInputs target takes content files as its input. The LibraryManagerRestore on the other hand doesn't produce content items. If you apply the following workaround, the issue disappears:

...
  <PropertyGroup>

<ResolveCurrentProjectStaticWebAssetsInputsDependsOn>LibraryManagerRestore;FixLibManRestore;$(ResolveCurrentProjectStaticWebAssetsInputsDependsOn)</ResolveCurrentProjectStaticWebAssetsInputsDependsOn>

  </PropertyGroup>
  
  <Target Name="FixLibManRestore" AfterTargets="LibraryManagerRestore">
  <ItemGroup>
            <Content  Include="%(FilesForPackagingFromProject.Identity)" Exclude="@(Content)">
            </Content>
        </ItemGroup>
		
  </Target>

...

TFTomSun avatar Jul 08 '21 12:07 TFTomSun

Thanks for the report. We are aware of a few issues when working with Razor Class Libraries. I'm working on a proposal currently, and I'll include this work into that.

sayedihashimi avatar Oct 28 '21 20:10 sayedihashimi

Is there any progress? I have just spent too much time figuring out that this issue caused a production failure

Tragetaschen avatar Jun 09 '22 08:06 Tragetaschen

Any update on this? If there is a proposed solution, why not use it?

theknut avatar Dec 15 '23 08:12 theknut