Benchmarks icon indicating copy to clipboard operation
Benchmarks copied to clipboard

Use agent names

Open sebastienros opened this issue 2 years ago • 3 comments

@CarnaViire Could your try this file locally and tell me if it's working like before the change? This way we don't have to copy the profile, we can just assign each job on the machine role we want.

sebastienros avatar Apr 15 '22 18:04 sebastienros

Sorry for the delay @sebastienros and thanks for the change! I've checked it, and there is a problem: while the machines are picked up correctly, the serverAddress variable is not updated, so it still has application machine IP, but the server is being run on load machine 😢

CarnaViire avatar Apr 20 '22 15:04 CarnaViire

Can you share a command line I could try to debug?

sebastienros avatar Apr 20 '22 16:04 sebastienros

  1. the commit before the change -- works, the IP used is 10.0.0.104 crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/f544bbe8bf89aa29bf71861ff2790dee869dcc35/scenarios/httpclient.benchmarks.yml --scenario httpclient-kestrel-get --profile aspnet-perf-lin --variable warmup=3 --variable duration=3

  2. the commit after the change -- doesn't work, the IP used is 10.0.0.102 (wrong) crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/dc2188505a1dcaf2b6cfaaaf7673651e89de36ad/scenarios/httpclient.benchmarks.yml --scenario httpclient-kestrel-get --profile aspnet-perf-lin --variable warmup=3 --variable duration=3

CarnaViire avatar Apr 20 '22 16:04 CarnaViire

Closing since you have mastered this now

sebastienros avatar Oct 17 '22 21:10 sebastienros