Benchmarks icon indicating copy to clipboard operation
Benchmarks copied to clipboard

Re-update JSON platform benchmarks to use JSON source generator

Open halter73 opened this issue 4 years ago • 4 comments
trafficstars

#1683 has been reverted. We should reapply it once preview7 is available.

halter73 avatar Jul 26 '21 18:07 halter73

@davidfowl https://dotnetcli.blob.core.windows.net/dotnet/Sdk/main/latest.version points to 6.0.100-preview.7.21379.14, can we revert #1688 now?

adamsitnik avatar Sep 06 '21 06:09 adamsitnik

We can, yes. I changed the source for the sdk to https://aka.ms/dotnet/6.0/daily/productCommit-win-x64.txt currently at 6.0.100-rc.1.21417.19

sebastienros avatar Sep 07 '21 15:09 sebastienros

@sebastienros could you please do that? I have no permissions in this repo and I can't click the "Revert" button

adamsitnik avatar Sep 07 '21 15:09 adamsitnik

Thanks for teaching me there is a "revert" button on GH, just tried it ;)

sebastienros avatar Sep 07 '21 15:09 sebastienros

Looks like this issue can be closed following https://github.com/aspnet/Benchmarks/pull/1698.

layomia avatar Sep 09 '22 16:09 layomia