AspNetCoreModule icon indicating copy to clipboard operation
AspNetCoreModule copied to clipboard

FREB: Usability: ASPNETCORE_EVENT_PROCESS_START_ERROR_MSG contains a number value without label

Open jhkimnew opened this issue 7 years ago • 0 comments

While testing FREB, I found that the last %x of the below string exists alone without any label, which is a usability issue.

#define ASPNETCORE_EVENT_PROCESS_START_ERROR_MSG L"Application '%s' with physical root '%s' failed to start process with commandline '%s', ErrorCode = '0x%x : %x."

I think we should add the label such as “ProcessStatus” or something else in front of it considering it is being used to set the process status code in the below code.

… if (GetExitCodeProcess(m_hProcessHandle, &processStatus)) { // make sure the process is still running if (processStatus != STILL_ACTIVE) { hr = E_FAIL; pStruErrorMessage->SafeSnwprintf( ASPNETCORE_EVENT_PROCESS_START_ERROR_MSG, m_struAppFullPath.QueryStr(), m_pszRootApplicationPath.QueryStr(), pStruCommandline->QueryStr(), hr, processStatus); goto Finished; } }

jhkimnew avatar Oct 18 '17 20:10 jhkimnew