git-deps graph: adjacent rows sometimes get inverted when adding nodes

graph: adjacent rows sometimes get inverted when adding nodes

Open aspiers opened this issue 10 years ago • 4 comments

I think this is probably a bug in webcola because the separation constraints look fine. The odd thing is that

d3cola.start()

seems to always turn it up the right way again.

Jan 10 '15 15:01 aspiers

Not seeing this any more since 284b0ca7 - assuming fixed.

Jan 12 '15 21:01 aspiers

ARGH. This just happened again, right in the middle of a demo video I was recording :-(

Jan 15 '15 01:01 aspiers

Is it because of your row_alignment_constraint logic? It is saying that the adjacent nodes on the same row can have this y range.

node[left].y - 100 <= node[right].y <= node[right].y + 100

why is it needed? shouldn't the y difference between two adjacent nodes be 0?

Jan 15 '15 05:01 qinfchen

No if it was zero then there would be no flexibility at all, and flexibility is often useful. It is possible that 100 is too high though.

Jan 16 '15 18:01 aspiers