Adam Spiers
Adam Spiers
Yeah, it's unfortunate that BittyTax reimplemented a lot of what Rotki already does. As [I previously noted](https://discord.com/channels/657906918408585217/797933632609189888/911388563491405916) (funnily, almost exactly a year ago!):  I can totally understand how it...
Looks great! Yes you are right the 0x prefix handling needs changing. I wonder if maybe we should generalise that to `%p` which formats as `0x` for EVM replacements and...
[**@0xmichalis**](https://github.com/0xmichalis) commented on [January 22, 2025 11:43 AM](https://github.com/rolod0x/rolod0x/pull/490#issuecomment-2607022364 "Wed Jan 22 2025 11:43:23 GMT+0000 - Replied by Github Reply Comments"): > > That would also allow future support for many...
Weird, thought I already had an issue for this, but yeah it's an obvious gap. Not a personal priority right now for me but PRs definitely welcome.
@joeyfigaro Awesome!
Hrm, depends on the third party deps I guess. What did you have in mind? In general I'm a fan of not reinventing wheels so if there are good libraries...
It's worth mentioning that I use ethers.js for validating EVM addresses. That said, regexps are still needed for detection and replacement. Probably the way to go is to copy how...
Agreed. The only other chain I personally care about is Bitcoin. Since we already have #490 for Solana, let's repurpose this one for Bitcoin and open others as needed.
@joeyfigaro If you are still interested in adding Bitcoin support you should definitely keep an eye on #490.