sns-sqs-big-payload icon indicating copy to clipboard operation
sns-sqs-big-payload copied to clipboard

Catch clause catches error which means that message will not go back to queue.

Open MathiasHaudgaard opened this issue 4 years ago • 2 comments

https://github.com/aspecto-io/sns-sqs-big-payload/blob/d5fb1535b840ecb9ffde2691f5e9ac3619cd90c1/src/sqs-consumer.ts#L163-L165

when integrating with lambda the above catch clause catches the error which causes the message to be removed from queue eventhough there was an error. Can you fix this?

Btw, really nice work on this package! 👍

MathiasHaudgaard avatar Oct 15 '20 13:10 MathiasHaudgaard

Hi @MathiasHaudgaard, good catch. We'll fix it. Thanks!

mzahor avatar Dec 17 '20 10:12 mzahor

Just realized that this fix will break a normal usage (outside lambda). Regarding lambda, I think subscribing to this event in the lambda and throwing an error should fix the issue. Just need to test it and update the docs.

mzahor avatar Dec 17 '20 10:12 mzahor