opentelemetry-ext-js icon indicating copy to clipboard operation
opentelemetry-ext-js copied to clipboard

Published 20 hours ago • verified publisher icon aspecto-io

Document supported versions

Open punya opened this issue 3 years ago • 3 comments
trafficstars

Thank you for building these instrumentation libraries!

When looking at the instrumentation libraries in https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node, I found it very useful to see the supported versions listed for each library (i.e., the versions of foo supported by @opentelemetry/instrumentation-foo).

Would it be possible to add something similar to the libraries in this repo? I'm especially curious if the Mongoose instrumentation supports Mongoose v6.

punya avatar Aug 15 '22 14:08 punya

Hi @punya Thank you for your interest. I too think it could be great to add this information to the README. Would you be interested in contributing a PR that adds this info?

The mongoose instrumentation will soon be upstreamed to the contrib repo, so I can also add this info when migrating the code there.

blumamir avatar Aug 18 '22 06:08 blumamir

I don't know what versions are supported, so I'm not sure how I'd make that PR!

punya avatar Aug 18 '22 22:08 punya

upstream the instrumentation to contrib repo, with test-all-version, support for v6 and documentation in README

https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1131

Thanks for bringing it up :)

blumamir avatar Aug 29 '22 07:08 blumamir