opentelemetry-ext-js icon indicating copy to clipboard operation
opentelemetry-ext-js copied to clipboard

Published 20 hours ago • verified publisher icon aspecto-io

Socket.io: `connection` should be a reserved event

Open rauno56 opened this issue 4 years ago • 2 comments

See https://github.com/socketio/socket.io-website/issues/277

The docs don't say that and maybe the maintainers have a good reason here, but, conceptually, if disconnect and disconnecting are reserved, so is connection.

rauno56 avatar Jul 09 '21 09:07 rauno56

If I understood this conversation correctly, potentially, a client could emit a connection event. So we should treat the connection as a reserved event only when instrumenting the Server instance and not the Socket.

mottibec avatar Jul 12 '21 06:07 mottibec

and looks like we need to also treat new_namespace as reserved for the Server, right?

blumamir avatar Jul 12 '21 08:07 blumamir