rules_ts icon indicating copy to clipboard operation
rules_ts copied to clipboard

refactor: change typechecking validation action to output gorup

Open jbedard opened this issue 1 year ago • 1 comments

This way tsc is not forced to always run as a validation action in the background and instead invoked only when the *_typecheck test is run.

Currently this only effects the noEmit case.

In the future this will allow the isolatedDeclarations fast-path to avoid running type-checking at all unless bazel test is run. This way something such as ibazel run //devserver will not be blocked waiting for the validation action to run in the background.


Changes are visible to end-users:no

Test plan

  • Covered by existing test cases

jbedard avatar Sep 09 '24 20:09 jbedard

Test

All tests were cache hits

87 tests (100.0%) were fully cached saving 8s.


Buildifier      Format

aspect-workflows[bot] avatar Sep 09 '24 20:09 aspect-workflows[bot]