rules_swc icon indicating copy to clipboard operation
rules_swc copied to clipboard

Published 20 hours ago • verified publisher icon aspect-build

Update SWC to re-enable sandbox

Open bazaglia opened this issue 2 years ago • 1 comments

Now that https://github.com/swc-project/swc/issues/4057 has been closed, if the SWC binary being used by rules_swc is updated to v1.2.218, it should be possible to remove the flag that disables the sandbox:

https://github.com/aspect-build/rules_swc/blob/29f5a69ec3636920d11c33576f2dc2d295be7a01/.bazelrc#L6-L8

bazaglia avatar Jul 21 '22 09:07 bazaglia

I took a stab at this: https://github.com/aspect-build/rules_swc/pull/97/files#r1000754748

but seems like there's still an SWC bug :(

alexeagle avatar Oct 20 '22 15:10 alexeagle

I'm working on this

realtimetodie avatar Dec 24 '22 22:12 realtimetodie

Looks like we're just waiting on the next SWC release and we can fix this. It doesn't need to be a breaking change, we just document that users still have to use the workaround if their swc version is less than X

alexeagle avatar Dec 27 '22 16:12 alexeagle

fixed in #57

alexeagle avatar Jan 07 '23 00:01 alexeagle