rules_js icon indicating copy to clipboard operation
rules_js copied to clipboard

test: add e2e test containing transitive npm_package deps

Open jbedard opened this issue 3 years ago • 3 comments

This adds an extra indirect dependency to the npm_link_package test to ensure indirect deps are passed along to runtime.

The second commit adds an esm version of that test. Basically copy and pasted and switched to esm which requires some extra node flags and minor other differences. Currently the file structure and files are very similar so a visual diff between the two nicely shows the differences.

jbedard avatar Jul 07 '22 00:07 jbedard

Hey do you still want to finish this one?

alexeagle avatar Aug 02 '22 14:08 alexeagle

Now that we have Greg's changes I'll give it a shot 👍

jbedard avatar Aug 02 '22 17:08 jbedard

@gregmagolan this is passing now and ready

jbedard avatar Aug 31 '22 21:08 jbedard