rules_jest icon indicating copy to clipboard operation
rules_jest copied to clipboard

[Bug]: *_update_snapshots target is generated when "snapshots" is set to False

Open fa93hws opened this issue 1 year ago • 1 comments

What happened?

The doc says

snapshots: If True, a {name}_update_snapshots binary target is generated

However, from the source code, {name}_update_snapshots will be generated even if snapshots is False https://github.com/aspect-build/rules_jest/blob/v0.19.6/jest/defs.bzl#L243-L263

Version

Development (host) and target OS/architectures:

Output of bazel --version: 6.4.0 Irrelevant to the issue though.

Version of the Aspect rules, or other relevant rules from your WORKSPACE or MODULE.bazel file: 0.19.6

Language(s) and/or frameworks involved:

How to reproduce

No response

Any other information?

No response

fa93hws avatar Jan 16 '24 05:01 fa93hws

Seems like a minor improvement we'd probably take.

arrdem avatar Apr 25 '25 18:04 arrdem