aspect-build
[Bug]: Reliance on `~` character for apparent->canonical repo name mapping
What happened?
We assume we can search for tilde here: https://github.com/aspect-build/rules_js/blob/b1dc67f34cfbe06dac06ea7c708d48e869df733e/npm/private/npm_translate_lock_helpers.bzl#L519 but this is not a guarantee from Bazel.
context: https://bazelbuild.slack.com/archives/C014RARENH0/p1719237766005439 from @fmeum
PSA: It may be necessary for Bazel to change the separator character used in canonical repository names (currently ~) to fix https://github.com/bazelbuild/bazel/issues/22865, maybe even already for 7.2.1. That means that it's a good time to remove any reliance on this particular character from rulesets. I just did this for Gazelle, which might provide some ideas on how to do this: https://github.com/bazelbuild/bazel-gazelle/pull/1835
Version
HEAD
How to reproduce
No response
Any other information?
No response
Note, https://gitlab.arm.com/bazel/toolchain_utils/-/commit/fc7d485887292676b5a87eb51c40f92aa6343b6b shows one approach for fixing this.
--incompatible_use_plus_in_repo_names was released in 7.3.0rc1, we should start testing all our repos with this.
rules_js fixed by https://github.com/aspect-build/rules_js/pull/1927
We don't know of issues in other rulesets, will file on them if users report any.