bazel-lib icon indicating copy to clipboard operation
bazel-lib copied to clipboard

fix: jq.md toolchains reference

Open kolloch opened this issue 1 year ago • 2 comments

A simple documentation-only fix.

kolloch avatar May 10 '24 08:05 kolloch

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 10 '24 08:05 CLAassistant

I don't think this would work, genrule's expect a target that materializes the toolchain type and returns some providers, OTOH toolchain types are not materialized if you just depend on toolchain type.

thesayyn avatar May 11 '24 17:05 thesayyn

Also, if there's a doc-only change, it should reflect an identical edit to an example/ or e2e/ test code change, so we know it's load-bearing and functional.

I'm closing PRs just to clean up the GH repo but please feel free to re-open if we got it wrong.

alexeagle avatar Jul 19 '24 19:07 alexeagle