aspect-cli icon indicating copy to clipboard operation
aspect-cli copied to clipboard

[Bug]: `aspect configure` behaves inconsistently

Open walkerburgin opened this issue 3 months ago • 4 comments

What happened?

Bumping aspect-cli to 2024.45.21 and running bazel configure locally resulted in diffs that looked like this:

go_library(
     # ...
     deps = [
-        "@com_github_fatih_color//:go_default_library",
-        "@com_github_spf13_cobra//:go_default_library",
+        "@com_github_fatih_color//:color",
+        "@com_github_spf13_cobra//:cobra",
     ],
     # ...
)

Running bazel configure on that commit on GitHub actions (ubuntu-latest) fails and produces the inverse diff, and I haven't been able to figure out why.

I bisected the source of the original diff to ad74a54410d2ece088712e9bb47f9a871b939c99.

Version

Development (host) and target OS/architectures:

Output of bazel --version:

Bazelisk version: 1.23.0
Aspect CLI OSS version: 2024.45.21-2252fc6 (with local changes)
Build label: 7.3.1
Build target: @@//src/main/java/com/google/devtools/build/lib/bazel:BazelServer
Build time: Mon Aug 19 16:41:27 2024 (1724085687)
Build timestamp: 1724085687
Build timestamp as int: 1724085687

Version of the Aspect rules, or other relevant rules from your WORKSPACE or MODULE.bazel file:

bazel_dep(name = "rules_go", version = "0.50.1")
bazel_dep(name = "gazelle", version = "0.39.1")

Language(s) and/or frameworks involved: go

How to reproduce

- Clone https://github.com/walkerburgin/aspect-configure-repro
- Run `bazel configure`. Observe (hopefully?) that the BUILD files are up to date
- Look at that repository's GitHub actions (e.g. [here](https://github.com/walkerburgin/aspect-configure-repro/actions/runs/11761213195/job/32762696326)) and observe that running `bazel configure` fails.

Any other information?

No response

walkerburgin avatar Nov 10 '24 01:11 walkerburgin