setuptools-golang icon indicating copy to clipboard operation
setuptools-golang copied to clipboard

Pipe stdout and stderr to devnull while doing ldflag checks

Open ankrgyl opened this issue 3 years ago • 12 comments

Fixes #48 by simply piping stderr and stdout to /dev/null.

ankrgyl avatar Sep 25 '22 17:09 ankrgyl

can you do the other half of the comment and verify it works on the other platforms? sometimes the compiler is fiddly when piped

asottile avatar Sep 25 '22 17:09 asottile

Do you have any tips on how? I wasn't sure whether the CI tested it on the set you care about or not. Apologies if I missed something obvious in the repo/instructions.

ankrgyl avatar Sep 25 '22 17:09 ankrgyl

CI gets linux -- you'll probably need to poke around manually on windows, macos (clang and gcc). we used to test them in CI but those platforms are significantly unstable and slow to test so they were removed

asottile avatar Sep 25 '22 18:09 asottile

Ah ok. I don't have a windows machine unfortunately -- happy to leave this in the abyss in case someone else feels compelled to test it further.

ankrgyl avatar Sep 25 '22 19:09 ankrgyl

you can get free VMs from https://modern.ie

asottile avatar Sep 25 '22 19:09 asottile

I unfortunately don't have cycles to set that up and manually test at the moment, but will try to come back to it another time.

Thank you so much for producing this library btw, it solves a very real need.

ankrgyl avatar Sep 25 '22 19:09 ankrgyl

Picking up this conversation @asottile since it's super interesting to me. Any chance I can contribute CI that helps unblock this? I'm happy to lift something similar to what I did in hiredis-py for [freebsd])(https://github.com/redis/hiredis-py/blob/master/.github/workflows/freebsd.yaml) and OSX and/or Windows WDYT?

Given that the fix uses subprocess.DEVNULL, which under the hood uses os.devull - it's should be portable.

chayim avatar Jul 24 '23 13:07 chayim

no thanks, I have no intention of supporting the other platforms and especially if it means making CI 10-20x slower

asottile avatar Jul 24 '23 13:07 asottile

Fair. Is there some other way to get this merged in?

chayim avatar Jul 24 '23 14:07 chayim

have you read the thread including my specific instructions above?

asottile avatar Jul 24 '23 14:07 asottile

Indeed. This was part of why I offered the CI change.

chayim avatar Jul 24 '23 14:07 chayim

no, you didn't read because if you did you would have seen:

we used to test them in CI but those platforms are significantly unstable and slow to test so they were removed

and then you wouldn't have suggested CI

asottile avatar Jul 24 '23 14:07 asottile