all-repos icon indicating copy to clipboard operation
all-repos copied to clipboard

Adding check for https protocol for repositories

Open palikar opened this issue 5 years ago • 4 comments

This should fix the problem outlined in #101

palikar avatar Feb 22 '20 11:02 palikar

actually, looking at this again I don't see how this fixes your problem (or how a user would configure the settings you've added). all-repos also always generates repositories with ssh remotes and I don't think this changes that?

asottile avatar May 12 '20 15:05 asottile

@asottile This maybe comes a little bit late but oh well. I fixed issues and tired adding a test for the new branch in the code. I am not sure if I've done it "properly" and I am pretty user it's kind of hacky.

palikar avatar May 12 '20 15:05 palikar

actually, looking at this again I don't see how this fixes your problem (or how a user would configure the settings you've added). all-repos also always generates repositories with ssh remotes and I don't think this changes that?

oh, ok, I though that the remote URL can have two forms depending on how the repo was cloned. Does that mean that #101 is not an actual issue?

palikar avatar May 12 '20 15:05 palikar

I'm not sure exactly -- it's certainly possible that someone writes an all-repos plugin which produces repositories with other protocols -- but none of the currently known plugins do so

asottile avatar May 12 '20 15:05 asottile