Gurpreet Singh

Results 23 comments of Gurpreet Singh

Sure @SeanFeldman I will get the sorted.

@SeanFeldman I have migrated this to XUnit. Could you please also have a look at the workflow (not my strong suite)

> I don't recall wherever PR build should have a version or not. @ErikMogensen do you remember? > > ![Screenshot_2024-08-12-07-29-57-87_40deb401b9ffe8e1df2f1cc5ba480b12](https://private-user-images.githubusercontent.com/1309622/357065965-5ac35287-75a2-4cb7-9eb2-d22c5c71b6b6.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM0NzE0NjEsIm5iZiI6MTcyMzQ3MTE2MSwicGF0aCI6Ii8xMzA5NjIyLzM1NzA2NTk2NS01YWMzNTI4Ny03NWEyLTRjYjctOWViMi1kMjJjNWM3MWI2YjYuanBnP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTJUMTM1OTIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjE2ZmRmNjU5ZGY1Nzg0MWQ2M2UwNmIxNTc0ZGMwMDU1MWEzZDRhMTM4ZmMxZjhjYWI2MDNhNTA0ZGI3N2JmMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.4jCNF3FP3P8PFnAjOHj5wNQAyFLiOyaWT-_Tlo-mq3M) I added default input for workflow manual build that is...

So what is next ? who will complete the PR ?

> > So what is next ? who will complete the PR ? > > Patience. This is not paid work, and people have their own priorities :) Apologies, I...

> @asos-gurpreetsingh, do you plan to complete this one? Erik pointed out one [last thing](https://github.com/paolosalvatori/ServiceBusExplorer/pull/801#issuecomment-2294802536) that needs attention. Hi Yes I will pick this weekend, i was out on holiday

> I tested to build this branch using `dotnet build -c RELEASE -p:GenerateAssemblyInfo=true,AssemblyVersion=0.1.2.3,InformationalVersion=0.0.1.1`. It sets File version to the same value as the Assembly version, which we don't want. Assembly...

> Yes, we want to be able to set different versions. Thinking of this, I want the assembly version to be set using a file belonging to the project of...

> There is also an issue with the build. build is fixed.

> > > Yes, we want to be able to set different versions. Thinking of this, I want the assembly version to be set using a file belonging to the...