Andrea Sorbini

Thank you for this contribution @emersonknapp, looks good to me. It makes sense that the `service_callback` would be allowed to invoke (at least some) APIs on the service. As you...

I have to unfortunately retract some of my previous comment after having investigated the changes a bit further. I tried to verify the fix using the new test from ros2/rcl#1081...

My guess was that these errors might have had something to do with the fact that `rcutils` uses `GetSystemTimePreciseAsFileTime()` while Connext uses `_ftime()`. I posited that the problem might be...

I'd like to suggest renaming the two new RMW functions used to access and set the content-filter expression and parameters to be slightly more appropriate. Quoting myself from a [comment](https://github.com/ros2/rmw_connextdds/pull/68#discussion_r735995595)...

Hi @xander-m2k, thank you for reporting this issue. I will try to reproduce it soon, but on the top of my head, I suspect the issue might lie in the...

Hi @maspe36, The problem comes from your use of keys, which is not supported by ROS 2. Even though the ROS 2 code generator is able to parse your IDL,...

This PR resolves some test failures in `interactive_markers` which were identified in [rmw_connextdds#22](https://github.com/ros2/rmw_connextdds/pull/22#issuecomment-816438687).

> It would be great if there would be a way to check if the user set these qos settings in the qos profile file, and only apply these defaults...

I've have reviewed these changes with @GerardoPardo and we both agreed that it would be better to align these settings with the built-in profile `Optimization.ReliabilityProtocol.Common` (available in 6.x, used to...

Turns out the failures in `TestInteractiveMarkerClient.states` have unrelated to reliability protocol configuration (see #40). I'm still leaving this PR open for now, because I think it would be good to...