Alan Somers

icon location Longmont, Colorado, USA

Results 656 comments of Alan Somers

Fix the build with the next version of libc

This PR sacrifices a little bit of type safety in order to build successfully with both old and new versions of libc. I'm not sure if we should merge it,...

Consider using a command runner to wrap the commonly used commands

I've never gotten into the habit of using any of those. But I'd be willing to give it a try for Nix.

Use from_bits_retain for all Termios wrapper fields.

> > Would this PR fix #2071 ? > > I think so, can you test it? No, I can't. I don't have an Illumos system. Maybe @nospam3089 can test...

`poll` / `PollFd` can no longer take `-1` as descriptors

> poll could usefully take &mut [Option]? Sounds good to me too

Definition of the `SockaddrFromRaw` trait

I don't understand what problem this PR would solve. Could you please explain?

Definition of the `SockaddrFromRaw` trait

> The only way to ensure it is initialized when returning from `recvmsg` is to either: > > * initialize it before calling `recvmsg` > > * write "bad" bytes...

Add `signal_ignore()` and `signal_default()`

I can see the value of this PR; it allows something to be done safely that was previously only possible unsafely. It also avoids the problem that the existing `sigaction`...

Add IPPROTO_IP variant to SockProtocol

To define two enum values that have the same representation, create a constant instead. See `SockProtocol::CanRaw` for an example.

`recvfrom`, `recvmsg` and `recvmmsg` might return uninitialized addresses when using connection-mode sockets

Unless this can violate some other invariant of SockaddrIn, it isn't unsound. I assume you're referring to the unsoundness that results from reading uninitialized memory? In this case, though the...

`recvfrom`, `recvmsg` and `recvmmsg` might return uninitialized addresses when using connection-mode sockets

We shouldn't need to zero it first. As far as the compiler is concerned, that FFI call always initializes the return argument. We should just check the sin_family field, the...