Alan Somers

Results 656 comments of Alan Somers

Since you're in here, would you mind adding doc comments for the epoll stuff?

Still needs a CHANGELOG entry.

So apparently stable compilers don't support this yet. https://github.com/rust-lang/rust/issues/64926 .

Since we're pre-1.0, we don't technically have to maintain backwards-compat. And in the past, we sometimes haven't. If you were only going to modify one or two functions, I'd say...

The extension trait sounds confusing to me, just because it's such a big break from Nix's existing API.

#1874 adds I/O safety to signalfd

Actually, susurrus meant that you should report a bug to Rust's libc, here: https://github.com/rust-lang/libc . That crate defines the FFI wrappers for all standard C structures.

Sure. If you're motivated, create a PR for it.

Yeah, I think it's time to do it. I for one don't have any big outstanding PRs.

No, I don't have any quick guesses.