Aaron Meurer

Results 1002 comments of Aaron Meurer

nsimplify is inexact. I don't think we should be using it in symbolic routines.

``` **Status:** Valid **Labels:** Integration ``` Original comment: http://code.google.com/p/sympy/issues/detail?id=4120#c1 Original author: https://code.google.com/u/[email protected]/

You need to actually install the requirements. The build doesn't do that for you automatically. The requirements file is just there to give you something to pass to pip to...

Looks like the accessibility concern was fixed upstream. Any other comments here? Should we try to merge this for the release, or is it too late for that?

They could in principle. We would need to manually apply the change to the release tag, build the docs, then copy that to the site. It's not exactly a clean...

I was hoping we could just change the base but apparently I made this branch after the release branch, so it would have to be backported manually.

It won't work until they release, although if we merge this before then it will automatically start working once they do.

I restarted the Circle build, so the docs preview should be built with the latest packages.

It looks like it did use 0.3.0 https://app.circleci.com/pipelines/github/sympy/sympy/746/workflows/15c3e7c7-c5e3-485f-8bb9-52305a225a86/jobs/2148?invite=true#step-103-23

I would suggest building this PR locally to confirm.