helm-git icon indicating copy to clipboard operation
helm-git copied to clipboard

Published 20 hours ago • verified publisher icon aslafy-z

fix(helm-git): multiple fixes

Open GMartinez-Sisti opened this issue 1 year ago • 7 comments

Why

I was trying this awesome plugin, but found some issues with the way I wanted to use it. I want to be able to use packaged helm charts from a branch, the charts and index.yaml might be in the root folder of the repository and this was not allowed.

Also had to set the url to git+ssh://[email protected]/org/repository/path/package-x.x.x.tgz?ref=branch&sparse=0&depupdate=1&package=0 in index.yaml on all the packages for this work.

What

  1. add trace: makes it easier to troubleshoot
  2. allow using repository root folder: there was an assumption that there would be a path with @
  3. ensure we have the latest from ref: when using HELM_GIT_REPO_CACHE the branch wouldn't be updated, probably the initial intention was to only use tags
  4. lint file: shellcheck

GMartinez-Sisti avatar Sep 01 '23 14:09 GMartinez-Sisti

Thank you for the contribution 🙏 I'm currently on vacation, I will take a look once back in a few days.

aslafy-z avatar Sep 01 '23 16:09 aslafy-z

Thank you for the contribution 🙏 I'm currently on vacation, I will take a look once back in a few days.

Thank you for the feedback. Enjoy your vacations! 🌴

GMartinez-Sisti avatar Sep 01 '23 18:09 GMartinez-Sisti

Ping 👼

GMartinez-Sisti avatar Dec 23 '23 10:12 GMartinez-Sisti

Hey there! Sorry for the long delay and thank you for pinging again! This looks good! Can you please add a test to validate that we can now refer to the root without using @ and that it still works with the old way? Thank you!

aslafy-z avatar Jan 13 '24 13:01 aslafy-z

@GMartinez-Sisti hey, I would like to merge this PR, let me know if you're able to do the required change. I may take the PR over if not.

aslafy-z avatar Apr 11 '24 07:04 aslafy-z

@GMartinez-Sisti hey, I would like to merge this PR, let me know if you're able to do the required change. I may take the PR over if not.

Hi @aslafy-z, sorry for not picking this up earlier! I already lost context for this PR 😬 Feel free to take it 😄

GMartinez-Sisti avatar Apr 11 '24 10:04 GMartinez-Sisti

add trace: makes it easier to troubleshoot

Ported with https://github.com/aslafy-z/helm-git/pull/266

allow using repository root folder: there was an assumption that there would be a path with @

See #267, not sure how it would behave with GitLab multi level hierarchy for instance. Will keep as a draft until I find a solution.

ensure we have the latest from ref: when using HELM_GIT_REPO_CACHE the branch wouldn't be updated, probably the initial intention was to only use tags

Wouldn't this defeat the cache? What would be the right time to refresh for you?

lint file: shellcheck

Ported with #268. It would be a nice to have as a pre-commit step/in the ci.

aslafy-z avatar Apr 11 '24 18:04 aslafy-z