orama icon indicating copy to clipboard operation
orama copied to clipboard

Support query clauses

Open DanieleFedeli opened this issue 2 years ago • 9 comments

Targets #15 Functionality is ready. I need some benchmarks and to resolve conflicts.

DanieleFedeli avatar Jul 20 '22 07:07 DanieleFedeli

@micheleriva Benchmarks:

Screenshot 2022-07-20 alle 21 14 16

Honestly, I am not happy with the range of query results. Right now I do a linear search over keys. I will try something non-linear.

DanieleFedeli avatar Jul 20 '22 19:07 DanieleFedeli

Thank you @anonrig I will work on that soon :clinking_glasses:

DanieleFedeli avatar Jul 22 '22 10:07 DanieleFedeli

Managed to get a better benchmark by changing the index data structure.

Screenshot 2022-07-22 alle 19 43 02

I will solve the conflicts, adjust the document deletion and I'm done.

DanieleFedeli avatar Jul 22 '22 17:07 DanieleFedeli

Hi @micheleriva, Is there something wrong with this PR? I can fix it if that is the case

DanieleFedeli avatar Jul 28 '22 17:07 DanieleFedeli

Hey @DanieleFedeli, I'm putting this PR on hold until we merge a major change from the simple-structures branch

micheleriva avatar Jul 29 '22 07:07 micheleriva

Ok, please write a comment when we can merge this so I will resolve conflicts

DanieleFedeli avatar Jul 29 '22 13:07 DanieleFedeli

@micheleriva May I start developing the plugin?

DanieleFedeli avatar Aug 28 '22 15:08 DanieleFedeli

@DanieleFedeli we're still working on the hooks system, I'd recommend waiting for it as it would simplify the work by a lot 🙏

micheleriva avatar Aug 28 '22 16:08 micheleriva

@micheleriva I have been busy this period, I did not follow Lyra.

~Are hooks integrated?~ I saw that only an insert hook is available. Is it planned to have more hooks? I think for this feature I will need for example:

  • onSearch to make the intersection between Lyra normal result and the plugin one
  • onDelete to remove the indexes of the deleted document

DanieleFedeli avatar Sep 18 '22 09:09 DanieleFedeli