B2G-flash-tool icon indicating copy to clipboard operation
B2G-flash-tool copied to clipboard

Restoring profile fails on latest build, wrongly thinks new version is smaller than backup

Open mikehenrty opened this issue 9 years ago • 11 comments

Whenever I update gecko on my aries device using builds from here [1], I see the following output and the profile does not get restore. I have to comment out the version check in the backup_restore_profile.py script to get the restore to work properly. I am willing to provide my profile if that will help.

2015-06-10 15:39:20,369 - main - INFO - Target device [None] 2015-06-10 15:39:20,369 - main - INFO - Checking profile... 2015-06-10 15:39:20,370 - main - INFO - The Version of Backup Profile: 41.0a1_20150608200123/20150608200123 2015-06-10 15:39:20,397 - main - WARNING - Can not pull profiles.ini from /data/b2g/mozilla to /var/folders/3r/ybzw4qx13xjg_kjnr753nwnc0000gn/T/backup_restore_wFo_qB 2015-06-10 15:39:20,397 - main - WARNING - The version on device is smaller than backup's version

  1. https://tools.taskcluster.net/index/artifacts/#gecko.v1.mozilla-central.latest.linux.aries-dogfood/gecko.v1.mozilla-central.latest.linux.aries-dogfood.debug

mikehenrty avatar Jun 10 '15 23:06 mikehenrty

@mikehenrty, after #353 was fixed, is this issue still happen?

askeing avatar Jun 30 '15 08:06 askeing

ref: #338

askeing avatar Jun 30 '15 08:06 askeing

Same problem for me, B2G-flash-tool is up to date, so it's not fixed by #353.

2015-08-03 21:56:47,584 - main - INFO - Target device [None] 2015-08-03 21:56:47,584 - main - INFO - Checking profile... 2015-08-03 21:56:47,585 - main - INFO - The Version of Backup Profile: 41.0a1_20150624160209/20150624160209 2015-08-03 21:56:47,618 - main - WARNING - Can not pull profiles.ini from /data/b2g/mozilla to /tmp/backup_restore_OHQQKk 2015-08-03 21:56:47,618 - main - WARNING - The version on device is smaller than backup's version.

I'm on a Flame btw, flashed base image v18D_nightly_v4 and b2g-42.0a1.en-US.android-arm.tar.gz. Version number for Firefox OS is 2.5 now, it was 3.0 before.

ghost avatar Aug 03 '15 21:08 ghost

I disabled the comparison and it worked. I add the versions here for reference. It should have checked 42 >= 41 (True).

2015-08-03 22:25:42,921 - main - INFO - The Version of Backup Profile: 41.0a1_20150624160209/20150624160209 2015-08-03 22:25:43,257 - main - INFO - The Version of Device Profile: 42.0a1_20150803030210/20150803030210

ghost avatar Aug 03 '15 21:08 ghost

¡Hola @mikehenrty!

Can you please tell me which exact line needs to be commented out to workaround this issue?

¡Gracias!

alex-mayorga avatar Aug 13 '15 16:08 alex-mayorga

@alex-mayorga I commented out the follow line, as well else the corresponding else. Although for the record I haven't seen this issue myself for quite some time and was going to close it until @5p4m's comment.

https://github.com/Mozilla-TWQA/B2G-flash-tool/blob/5608d702bed9e226a9d7f9bd4b2d709a402696ae/backup_restore_profile.py#L236

mikehenrty avatar Aug 13 '15 16:08 mikehenrty

¡Gracias @mikehenrty!

I'm upgrading from 18Dv0 to 18Dv4 on a Flame and this bug bite me so at least here it is still an issue IMHO.

alex-mayorga avatar Aug 13 '15 16:08 alex-mayorga

I try to fix it in https://github.com/askeing/b2g-util-python Due to I cannot reproduce this issue, could you please help to have a try?

$ git clone https://github.com/askeing/b2g-util-python.git
$ cd b2g-util-python
$ virtualenv ENV
$ source ENV/bin/activate
$ python setup.py develop

Then you can run $ b2g_backup_restore_profile -b -v or $ b2g_backup_restore_profile -b --skip-version-check -v for testing (-v for verbose).

Thank you.

askeing avatar Aug 14 '15 10:08 askeing

@mikehenrty Could you please help to try b2g_util 0.07 [1]? It will raise exception when it cannot get version from backup file or device. And user can skip the version checking by --skip-version-check.

[1] https://pypi.python.org/pypi/b2g_util

askeing avatar Aug 20 '15 13:08 askeing

@askeing I haven't been able to reproduce this bug in a while, so for me the issue is fixed. Perhaps @alex-mayorga or @5p4m could try out your library and see if it fixes their issue?

mikehenrty avatar Aug 21 '15 16:08 mikehenrty

Sorry for the late reply. I just did a restore, I got the warning at first run and a working restore at the second run. While I think the warning is odd, it works for me.

FYI the versions were Backup Profile: 43.0a1_20150820202733/20150820200530 Device Profile: 43.0a1_20150905030228/20150905030228

ghost avatar Sep 05 '15 13:09 ghost