Asim R P comments

Results 15 comments of


                                            Asim R P

trafficstars

Report separate PostgreSQL and Greenplum versions in pg_controldata

@gfphoenix78 that change to `pg_auto_failover` is not right, it looks very Greenplum specific. If we have to make a change to pg_auto_failover, let's think if it will be accepted by...

Report separate PostgreSQL and Greenplum versions in pg_controldata

I had tried reverting `PG_CONTROL_VERSION` macro to upstream version and having a separate `GP_CONTROL_VERSION`. That patch seemed a lot more intrusive that the current proposal. If you guys feel strongly...

Report separate PostgreSQL and Greenplum versions in pg_controldata

> I believe we'd ship the modified pg_auto_failover tool along with gpdb in the gp7 release, right? We should try our best to use native `pg_auto_failover` and NOT to fork...

Report separate PostgreSQL and Greenplum versions in pg_controldata

Edit: let me change this patch, not you :)

Fix -Wunused-result compiler warnings

Looks good to me :+1: Not sure what the scope of this PR is but a quick grep through the main branch, after pulling commits from this PR, reveals some...