RL_Matrix icon indicating copy to clipboard operation
RL_Matrix copied to clipboard

Align with the Stable-baselines3 framework?

Open GeorgeS2019 opened this issue 1 year ago • 1 comments

I have written reasons why this is important for your degree; https://github.com/dotnet/TorchSharp/discussions/710#discussioncomment-9825413

GeorgeS2019 avatar Jun 20 '24 07:06 GeorgeS2019

  1. Instead of whats relevant to my dissertation I want to focus on best programming practices in modern C# and apply SOLID to the best of my ability. Aligning with SB3 is just going to make code-base a lot worse and less maintanable. If anything they (SB3 authors) should align with RLMatrix. 😎

  2. This project aims to provide a replacement to RLib rather than SD3 https://docs.ray.io/en/latest/rllib/index.html and I am going to gear it towards use with game engines.

  3. In later versions you will not have to implement IEnv interfaces by hand but rather use attributes and source generator will cook up relevant class for you, so you don't need to worry about it!

asieradzk avatar Jun 20 '24 08:06 asieradzk

I watched the .NET youtube where you presented your work.

You fail to understand what it means to align with SB3 and there is no evidence suggesting that your existing direction aligns with sb3.

You are free to delete this comment.

GeorgeS2019 avatar Oct 14 '24 12:10 GeorgeS2019

I watched the .NET youtube where you presented your work.

You fail to understand what it means to align with SB3 and there is no evidence suggesting that your existing direction aligns with sb3.

You are free to delete this comment.

you can always write adapter if you need it so badly. Right now the RLMatrix is going to move forward in the direction of attributes and code-generation.

asieradzk avatar Oct 14 '24 13:10 asieradzk