Asias He

Results 172 comments of Asias He

Changes in 49b14a914db83bc1755fd88a6b8165b017bd0499 - Rebased to latest master @avikivity As we discussed in the thread "[PATCH v1] gossip: make sleeping intervals configurable", you seem to have positive feedback. Can you...

> This PR does two separate things: > > * one is fixing node replacement behavior > > * the other is what the PR title actually says, making boot...

@kbr- Thanks for looking into this!

Changes in 9da855472c8afbd54d000ea5fee9c4223cc36da9: - Rename verb from GOSSIP_QUERY_TOKEN_STATUS to CLUSTER_RING_STATUS - Decouple the algorithm from gossiper class. They are now static function in gossiper.cc. - Add more comments

> Simpler code, less bugs. I see this as a very weak reason. I do not think sending more hashes introduces any significant complexity.

> Our standard solution for this is to use cluster features. Not include newitems in the hash until the cluster is upgraded. It's more flexibly, itallows you to change the...

> Can you give an example? There is a whole spectrum between having a single hash and sending everything unhashed, you can gradually remove information. Why do you think the...

> We need a command which we can use to inspect the full state of topology. If we don't have it, we should write one. We still want to be...

> But we still need to make a corresponding update of endpoint states, otherwise the change would not propagate to other nodes and synchronization would not converge. So endpoint states...

> The advantages of doing 2 are: > - more future proof, all operations in the block are automatically covered. We can add new operations which are waited for without...