gocd-build-github-pull-requests icon indicating copy to clipboard operation
gocd-build-github-pull-requests copied to clipboard
verified publisher icon ashwanthkumar

Plugin does not support whitelists

Open cfontes opened this issue 7 years ago • 2 comments

Would be nice to support white lists, specially with variable interpolation from environment variables in the material.

BTW, thanks for the plugin

cfontes avatar Oct 15 '18 11:10 cfontes

@cfontes A few questions so I understand this better

  • By Whitelists, do you mean white-listing on the branches or whitelisting on the paths in the repo that can trigger the build? If it's branches, Git Feature Branches already support it today.
  • If you're asking for white-listing the branches in other plugins (apart from FB plugin), can you please explain the use-cases where it might be used?

PS: We can't have environment variable based interpolation, but it should be possible to use Parameters.

ashwanthkumar avatar Nov 07 '18 04:11 ashwanthkumar

What about whitelisting on the paths in the repo? Is that possible/planned?

We have multiple independent components in the same git repo, and and without directory whitelisting support all the components are rebuild/retested every time, which wastes gocd agent resources and also increases the time that the PR becomes ready to be merged.

schweikert avatar Apr 04 '19 16:04 schweikert