Ashutosh Gupta

Results 98 comments of Ashutosh Gupta

Thanks @iwasakims for your comments. I missed one change which I have added in latest commit. After that change, it will work fine. Before the change, it is failing. ```...

@iwasakims - Can you please review the latest changes, Thanks.

> Hmm, hadoop_add_param does not work if the value contains `"`. (`HADOOP_OPTS='-XX:OnOutOfMemoryError="kill -9 %p"'` instead of previous `HADOOP_OPTS="-XX:OnOutOfMemoryError='kill -9 %p'"`) @ashutoshcipher > > ``` > $ export HADOOP_OPTS='-XX:OnOutOfMemoryError="kill -9 %p"'...

FYI: Checkstyle -0 showing here is not due changes in this PR.

@aajisaka - I have addressed you comments. Can you please review it again. Thank you so much.

@aajisaka - I have addressed your last comments. Please help in reviewing it again. Thanks.

Thanks @ZanderXu for review and approval. @aajisaka is the original reporter for this issue, may be he can help with additional review/suggestions.

@ZanderXu - Can we commit/merge this? (We dont have any other comments/suggestions) Thanks