masterPortfolio icon indicating copy to clipboard operation
masterPortfolio copied to clipboard

Need modification in experience cards.

Open ashutosh1919 opened this issue 4 years ago • 3 comments

I like below cards more than the existing design. It is @dineshnadimpalli's implementation. Good work.

@dineshnadimpalli, can you raise PR to add this to masterPortfolio.

Screenshot 2020-08-05 at 12 13 16 PM

ashutosh1919 avatar Aug 05 '20 06:08 ashutosh1919

@dineshnadimpalli, we need to change this thing that we need to make width 100% in this

ashutosh1919 avatar Aug 05 '20 06:08 ashutosh1919

Thanks @ashutosh1919 😁. Sure, will try something with 100% width and will also try adding the description part to this one.

dineshnadimpalli avatar Aug 05 '20 07:08 dineshnadimpalli

Now this task is open to anyone.

Please comment here if you want to take it up and I will assign it to you!

saiteja13427 avatar Jun 11 '22 10:06 saiteja13427

I can modify the cards of the site as per the pic given above, Assign me the task.

Vyomrana02 avatar May 06 '23 04:05 Vyomrana02

Sure @Vyomrana02, assigning it to you. Reach out in case of any queries!

saiteja13427 avatar May 06 '23 05:05 saiteja13427

image

Is this Okay??

Vyomrana02 avatar May 13 '23 12:05 Vyomrana02

@Vyomrana02 Looks good.

How about adding skill icons as well and if skill icons are not there, then maybe that empty space shouldn't be there?

saiteja13427 avatar May 13 '23 12:05 saiteja13427

Is this Okay!! I have removed blank space cause in the given cards we have an key field named languages so here in portfolio.js we dont have this field. The output after removing space is like this image

Vyomrana02 avatar May 13 '23 12:05 Vyomrana02

This also looks fine to me, what do you think @ashutosh1919, Should we add a description or skills to the cards?

Also @Vyomrana02, in the latest image I can see the vertical lines behind the blue circles, that shouldn't happen.

saiteja13427 avatar May 13 '23 12:05 saiteja13427

@saiteja13427 @Vyomrana02 I think we should include description for the job role.

ashutosh1919 avatar May 13 '23 13:05 ashutosh1919

Yeah, let us add description! @Vyomrana02 maybe you can add description and raise a PR

saiteja13427 avatar May 13 '23 13:05 saiteja13427

@Vyomrana02 have you raised a PR or are you still working in your fork? Coz I don't see PR here. Please attach it here if you have already raised.

ashutosh1919 avatar May 13 '23 13:05 ashutosh1919

@ashutosh1919 I have created PR and as per @saiteja13427 i have edited it. Output:- image

Vyomrana02 avatar May 13 '23 15:05 Vyomrana02

Merged in #296 .

Vyomrana02 avatar Sep 18 '23 14:09 Vyomrana02