masterPortfolio
masterPortfolio copied to clipboard
Need modification in experience cards.
I like below cards more than the existing design. It is @dineshnadimpalli's implementation. Good work.
@dineshnadimpalli, can you raise PR to add this to masterPortfolio.

@dineshnadimpalli, we need to change this thing that we need to make width 100% in this
Thanks @ashutosh1919 😁. Sure, will try something with 100% width and will also try adding the description part to this one.
Now this task is open to anyone.
Please comment here if you want to take it up and I will assign it to you!
I can modify the cards of the site as per the pic given above, Assign me the task.
Sure @Vyomrana02, assigning it to you. Reach out in case of any queries!
Is this Okay??
@Vyomrana02 Looks good.
How about adding skill icons as well and if skill icons are not there, then maybe that empty space shouldn't be there?
Is this Okay!!
I have removed blank space cause in the given cards we have an key field named languages so here in portfolio.js we dont have this field.
The output after removing space is like this
This also looks fine to me, what do you think @ashutosh1919, Should we add a description or skills to the cards?
Also @Vyomrana02, in the latest image I can see the vertical lines behind the blue circles, that shouldn't happen.
@saiteja13427 @Vyomrana02 I think we should include description for the job role.
Yeah, let us add description! @Vyomrana02 maybe you can add description and raise a PR
@Vyomrana02 have you raised a PR or are you still working in your fork? Coz I don't see PR here. Please attach it here if you have already raised.
@ashutosh1919 I have created PR and as per @saiteja13427 i have edited it.
Output:-
Merged in #296 .