masterPortfolio icon indicating copy to clipboard operation
masterPortfolio copied to clipboard

PNGs/SVGs instead of iconify

Open danielmarostica opened this issue 4 years ago • 2 comments

Some icons do not exist at iconify.design (scikit-learn, for example).

It would be great if it was possible to insert other images instead, in these sections:

image

danielmarostica avatar Jul 26 '20 17:07 danielmarostica

Yes I think we can do this. Feel free to raise a PR..

This is open for anyone to take up, feel free to comment here and tag me so that i can assign it to you!

saiteja13427 avatar Jun 07 '22 10:06 saiteja13427

Iconify now has scikit-learn icon. #219 updates Iconify to the latest version as of now, hence you can now include it in your portfolio.

dhruvkrishnavaid avatar Jun 22 '22 12:06 dhruvkrishnavaid

@saiteja13427 inserting images still an idea? I would love to take a look at this then 😄

dminkovski avatar May 04 '23 20:05 dminkovski

@dminkovski yes, it would be great if you can implement this.

Make sure that existing iconify option also works though!

Should I assign this issue to you?

saiteja13427 avatar May 05 '23 04:05 saiteja13427

@saiteja13427 Hey yes I will gladly have a look and try this out 😄

dminkovski avatar May 05 '23 08:05 dminkovski

@dminkovski Awesome, I am assigning it to you then, reach out to me if you face any issue as such!

saiteja13427 avatar May 05 '23 08:05 saiteja13427

Closing the issue as PR #288 adds the required functionality.

saiteja13427 avatar May 13 '23 12:05 saiteja13427