masterPortfolio icon indicating copy to clipboard operation
masterPortfolio copied to clipboard

Not everyone would want to give a nickname , so if nickname is not provided an "()" bracket is being rendered .

Open Ac-Srikanth opened this issue 4 years ago • 6 comments

This is not exactly an issue , but can i raise an PR regarding this ?

Ac-Srikanth avatar Jul 26 '20 15:07 Ac-Srikanth

@Ac-Srikanth Feel free to raise PR to resolve this issue. Btw, good observation. This is indeed a problem in my opinion.

ashutosh1919 avatar Jul 26 '20 16:07 ashutosh1919

@Ac-Srikanth, for now, you can go to src\containers\greeting\greetings.js and comment lines 20 to 22. This would do to hide the brackets.

rahulrachh avatar Jan 06 '21 05:01 rahulrachh

@ashutosh1919 @rahulrachh in replace of the nickname an waving emoji can be given by importing it in portfolio.js.

tamojit-123 avatar Jan 06 '21 09:01 tamojit-123

@ashutosh1919 @rahulrachh in replace of the nickname an waving emoji can be given by importing it in portfolio.js.

This is a good suggestion too.

rasam-hossain avatar Jan 06 '21 22:01 rasam-hossain

@tamojit-123 feel free to raise a PR to fix this as you described. I liked an idea.

ashutosh1919 avatar Jan 07 '21 04:01 ashutosh1919

This issue is now open for anyone to take up. Feel free to comment here and raise a PR if you want to contribute.

saiteja13427 avatar Jun 09 '22 07:06 saiteja13427

PR #284 fixes this issue. Marking it closed!

saiteja13427 avatar Apr 11 '23 18:04 saiteja13427