masterPortfolio
masterPortfolio copied to clipboard
Not everyone would want to give a nickname , so if nickname is not provided an "()" bracket is being rendered .
This is not exactly an issue , but can i raise an PR regarding this ?
@Ac-Srikanth Feel free to raise PR to resolve this issue. Btw, good observation. This is indeed a problem in my opinion.
@Ac-Srikanth, for now, you can go to src\containers\greeting\greetings.js
and comment lines 20 to 22. This would do to hide the brackets.
@ashutosh1919 @rahulrachh in replace of the nickname an waving emoji can be given by importing it in portfolio.js.
@ashutosh1919 @rahulrachh in replace of the nickname an waving emoji can be given by importing it in portfolio.js.
This is a good suggestion too.
@tamojit-123 feel free to raise a PR to fix this as you described. I liked an idea.
This issue is now open for anyone to take up. Feel free to comment here and raise a PR if you want to contribute.
PR #284 fixes this issue. Marking it closed!