masterPortfolio icon indicating copy to clipboard operation
masterPortfolio copied to clipboard

Published 20 hours ago • verified publisher icon ashutosh1919

Optional components

Open aash1999 opened this issue 2 years ago • 5 comments

Changes made : Made Star Me On Github button optional Made View Resume Button optional

aash1999 avatar Sep 22 '22 11:09 aash1999

@saiteja13427 please look into this PR

aash1999 avatar Sep 22 '22 13:09 aash1999

Thanks for the PR @aash1999

I was thinking it would be great if we have a object dedicated to enabling/disabling buttons and pages.

What do you think @ashutosh1919, shall we do that? Shall we have one customise object wherein users can enable/disable pages, some optional components, some buttons etc?

saiteja13427 avatar Sep 22 '22 14:09 saiteja13427

@saiteja13427 yes I agree. We should do something like that. Otherwise we need to write redundant if conditions.

ashutosh1919 avatar Sep 23 '22 00:09 ashutosh1919

Alright

@aash1999 would you like to take this up? We can open an issue, discuss it there and then go for it.

If you are willing to take this up then I will create an issue. Let me know.

saiteja13427 avatar Sep 23 '22 10:09 saiteja13427

@saiteja13427 sounds cool to me. I am in 🤓

aash1999 avatar Sep 23 '22 11:09 aash1999