masterPortfolio icon indicating copy to clipboard operation
masterPortfolio copied to clipboard

Modified Git Script To Persist Old Records

Open saiteja13427 opened this issue 3 years ago • 2 comments

Modified git script to persist the old records and add on top of it. Solves issue #159

Changes

  1. Modified the git script to persist old records.
  2. Added a clear: true key, value pair to the organisation, pull_request and issues JSON files to clear the records when a new user clones and runs the script for the first time.

Reason for changes

As we get only 100 records on every fetch to the API, there is a chance that for people with more than 100 PRs or 100 issues, the previous data will disappear.

To tackle this, we will now be appending any new data to the previous data.

Note: I did not format the JSON files, probably was done by husky pre-commit. Due to that, you will see huge change size. But the only change in those json files is clear: true.

saiteja13427 avatar May 26 '22 15:05 saiteja13427

@saiteja13427 merging this one will take time since it is not related to UI.

ashutosh1919 avatar Jun 05 '22 16:06 ashutosh1919

@ashutosh1919 Sure, I tried covering all the edge cases i could think of, do test it locally with your profile and let me know if you see any issues.

saiteja13427 avatar Jun 06 '22 08:06 saiteja13427