Ashutosh Narkar

Results 273 comments of Ashutosh Narkar

So adding more context to that statement would be helpful then.

@PietervdWerk this would be a good change to get in. Are you able to update the tests?

The ability to return an error seems like a good idea. > a backwards compatible change would be introducing a second interface that can validate tracing.Options Are you suggesting a...

> I am actually not sure how much concern just adding error as return type is as this interface is pretty specific to library use and also easy to fix...

Ok. So a new interface that returns an error and deprecating the old seems like a good option to me.

Thanks for filing this request. > The main benefit of this feature is that as an end user, I will have to use only one extensibility protocol in Envoy that...

Thanks for the context. > ext_proc is marked as production ready. What part of it is WIP? From https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/ext_proc_filter > This filter is a work in progress. Most of the...

This seems like a good addition. If you'd like to contribute the feature that would be great! We'd be happy to help with any questions, reviews etc. We could also...

Do we have a recording of the call?

Thanks for working through the steps. I agree we should update the documentation to include a note about the extra steps that need to taken on a Windows machine. If...