Mohammad Nejati

Results 144 comments of Mohammad Nejati

I'm uncertain about the interface, but something that eliminates the need for a temporarily allocated string would be ideal. Just to clarify what I mean: ```C++ auto host_and_port = url.authority().encoded_host_and_port();...

> what if the user wants to access the original header fields when they look at the trailers? by that time, the parser's internal buffer no longer has the data.......

There is also `serializer::prepare`, which returns the output buffer. we might want to rename it to `serialize` or `data`.

It seems you just forgot to pass `lazycsv::quote_char`. Using it like the following should resolve the issue: ```C++ using parser_t = lazycsv::parser< lazycsv::mmap_source, lazycsv::has_header, lazycsv::delimiter, lazycsv::quote_char, lazycsv::trim_chars>; ```

Thanks for the suggestion. Clients can also use [websocket::stream::secure_prng](https://www.boost.org/doc/libs/1_87_0/libs/beast/doc/html/beast/ref/boost__beast__websocket__stream/secure_prng.html) to disable the secure PRNG. Performance measurements are needed to determine how much gain is achievable by completely disabling masking and...

> Timings came out (server and client on the same low-end embedded platform, transferring 100 MB of messages) > > 1. 2776ms > 2. 2771ms > 3. 2161ms > >...

Thank you. Could you please check the `example` and `test` directories as well?

@ssam18 You can use the GitHub Action CI in your own fork to address the compile errors, since it won’t require approval to run each time.

> @ashtum Please let me know if this PR looks good? All files under `test/doc` and `example` should use `core::string_view` rather than `boost::string_view`. If needed, add `namespace core = boost::core;`...