mirrorsharp icon indicating copy to clipboard operation
mirrorsharp copied to clipboard

MirrorSharp keeps autocorrecting string to String

Open haacked opened this issue 3 years ago • 6 comments

Not sure if this is just a Roslyn setting or a MirrorSharp thing, but I figured you'd know. When I'm typing code and doing something like declaring properties, MirrorSharp keeps wanting to suggest String instead of string. Is this a setting I can control.

You can see it keep happening in this YouTube video I recorded using MirrorSharp in Abbot at the 11:58 mark: https://youtu.be/WaTkNraTGU8?t=718

haacked avatar Feb 19 '21 22:02 haacked

Thanks for reporting! I have tried to reproduce it and I am getting string higher in the autocomplete list than String, so it works fine, but in your video I can see String is higher.

I am not sure why -- I don't remember doing any manual sorting, so order must be coming from Roslyn, but I will investigate further.

ashmind avatar Feb 26 '21 23:02 ashmind

~At a first glance it should be in order tested here http://sourceroslyn.io/#Microsoft.CodeAnalysis.CSharp.EditorFeatures.UnitTests/Completion/CompletionProviders/CompletionProviderOrderTests.cs,42 so keywords should be high in the list.~

Edit: Nvm, not yet fully sure how the order gets defined, confirming.

To verify it's not a JS issue, can you check WebSocket completions message you are getting and what the order is there? image

ashmind avatar Feb 27 '21 00:02 ashmind

Screen Shot 2021-03-01 at 7 27 12 PM

haacked avatar Mar 02 '21 03:03 haacked

Looks like I get String before string

haacked avatar Mar 02 '21 03:03 haacked

Thanks! I'll investigate further. Which Roslyn library version are you using?

ashmind avatar Mar 03 '21 18:03 ashmind

Microsoft.CodeAnalysis.CSharp v3.8.0

haacked avatar Mar 03 '21 18:03 haacked