SolutionIcon icon indicating copy to clipboard operation
SolutionIcon copied to clipboard

VS 2019 support

Open NielsUll opened this issue 5 years ago • 6 comments

Do you plan to support VS 2019?

NielsUll avatar Dec 03 '19 11:12 NielsUll

Thanks for asking. Not sure -- eventually yes, but no specific timeline for it.

At my current workplace we mostly work at one solution as compared to 5 at the previous place, so for now I don't actively need this. Would be happy to accept a pull request though.

ashmind avatar Dec 04 '19 08:12 ashmind

I've started working on this but got stuck with the AsyncPackage thing, again. VS SDK really sucks. I've asked for help in the repo where they explain the "simplest way" to handle this, because none of that actually works.

(For now, I've just updated the version numbers and accepted loading of synchronous packages in VS 2019. That works well and is already really helpful when working with multiple solutions at the same time. But it probably can't be uploaded to the VS marketplace in this state. I also recommend 7+ Taskbar Tweaker to always ungroup VS windows so you can actually see this in the taskbar.)

ygoe avatar Nov 02 '20 12:11 ygoe

I have created a module for Windhawk that provides this support for 2017 and 2019: https://windhawk.net/mods/lm-vs-solution-icon

The icon generation code is based on this extension.

learn-more avatar Apr 23 '22 20:04 learn-more

@learn-more Interesting. Does it also load the solution-provided icon from the file? And can it handle VS 2022? (Now that VS 2019 shows a warning that it's no longer supported and we should finally upgrade to 2022.)

ygoe avatar Apr 25 '22 09:04 ygoe

@learn-more Interesting. Does it also load the solution-provided icon from the file? And can it handle VS 2022? (Now that VS 2019 shows a warning that it's no longer supported and we should finally upgrade to 2022.)

No, for now it only loads creates an icon from the filename. I was planning on adding support for the .editoricon.ico file, but nothing beyond that yet.

Currently I don't have access to a machine with 2022, so I was unable to test that.

learn-more avatar Apr 25 '22 10:04 learn-more

On this issue's topic: Maybe it's worth extending this new extension to also show icons instead of just funny colours that nobody will remember?

ygoe avatar Nov 17 '22 19:11 ygoe